Skip to content

feat(gRPC): add grpc client conn dump to help debug the conn and stream status #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Feb 14, 2025

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat(gRPC): 添加 grpc client 的连接 dump 信息帮助排查 conn 和 stream 的状态

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ppzqh ppzqh requested review from a team as code owners February 14, 2025 09:24
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from 418091f to ec38d8b Compare February 14, 2025 09:42
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 63.82979% with 34 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (4031e2a) to head (2358441).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/nphttp2/grpc/http2_client.go 48.00% 23 Missing and 3 partials ⚠️
pkg/remote/trans/nphttp2/conn_pool.go 80.00% 3 Missing and 2 partials ⚠️
pkg/remote/trans/nphttp2/grpc/transport.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1702   +/-   ##
========================================
  Coverage    63.78%   63.78%           
========================================
  Files          379      379           
  Lines        34328    34422   +94     
========================================
+ Hits         21895    21955   +60     
- Misses       11122    11150   +28     
- Partials      1311     1317    +6     
Flag Coverage Δ
integration 46.95% <0.00%> (-0.17%) ⬇️
unit 55.81% <63.82%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch 2 times, most recently from 8ca6d51 to 08ef8d4 Compare February 17, 2025 08:37
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from 08ef8d4 to aba86cb Compare March 17, 2025 03:43
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from aba86cb to a053eb7 Compare March 17, 2025 03:44
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch 2 times, most recently from c0ab717 to 744a0d5 Compare March 17, 2025 09:18
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from 5659a95 to 2b2b874 Compare March 17, 2025 09:58
DMwangnima
DMwangnima previously approved these changes Mar 17, 2025
@ppzqh ppzqh merged commit 62a39a2 into cloudwego:develop Mar 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants