Skip to content

fix(tool): some bugfix for kitex tool #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HeyJavaBean
Copy link
Member

@HeyJavaBean HeyJavaBean commented Feb 11, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(tool): kitex tool 的一些小修复

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  1. fix "initGoMod" function to create go.mod in given dir.
  2. simplify thriftgo execution, remove thriftgo version check.
  3. remove -rapid argument (no longer used.), rename local_thriftgo -> local-thriftgo (unify namestyle)
    zh(optional):
  4. 修复 initGoMod 函数,以便在给定的 curpath 目录创建 go.mod
  5. 简化 thriftgo 内嵌相关参数、删除了 thriftgo 进程唤起时的检查(默认内嵌了,不再必要了)
  6. 删除了 -rapid 参数(不再必要),将 local_thriftgo 参数修复为 local-thriftgo (统一命名风格)

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@HeyJavaBean HeyJavaBean requested review from a team as code owners February 11, 2025 11:50
@HeyJavaBean HeyJavaBean force-pushed the fix/bugfix_for_kitex_tool branch from 7057fce to 492b5c4 Compare February 11, 2025 11:52
@HeyJavaBean HeyJavaBean force-pushed the fix/bugfix_for_kitex_tool branch from 492b5c4 to 5b56e76 Compare February 11, 2025 11:56
@HeyJavaBean HeyJavaBean merged commit 56a1e36 into cloudwego:develop Feb 11, 2025
19 checks passed
HeyJavaBean added a commit to HeyJavaBean/kitex that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants