Skip to content

refactor: streamx api to adapt both grpc and ttheader streaming protocol and provide more user-friendly interface #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Mar 10, 2025
Merged

refactor: streamx api to adapt both grpc and ttheader streaming protocol and provide more user-friendly interface #1658

merged 49 commits into from
Mar 10, 2025

Conversation

jayantxie
Copy link
Member

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners January 7, 2025 03:33
YangruiEmma
YangruiEmma reviewed Feb 5, 2025
View reviewed changes
YangruiEmma
YangruiEmma reviewed Feb 5, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Feb 5, 2025
View reviewed changes
@jayantxie jayantxie force-pushed the refactor/streamx-api branch 13 times, most recently from 2bf2a16 to 1d9b475 Compare February 13, 2025 09:21
@jayantxie jayantxie force-pushed the refactor/streamx-api branch from 77c156f to 76dee17 Compare February 14, 2025 06:57
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.39922% with 161 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (9a261f9) to head (2d27d78).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/nphttp2/stream.go 76.82% 30 Missing and 5 partials ⚠️
client/option_ttstream.go 0.00% 15 Missing ⚠️
server/option_ttstream.go 0.00% 15 Missing ⚠️
client/stream.go 89.70% 9 Missing and 5 partials ⚠️
pkg/streaming/util.go 35.00% 13 Missing ⚠️
client/client.go 80.95% 8 Missing and 4 partials ⚠️
internal/client/option.go 82.25% 7 Missing and 4 partials ⚠️
pkg/circuitbreak/circuitbreak.go 15.38% 10 Missing and 1 partial ⚠️
client/option_stream.go 88.23% 6 Missing ⚠️
pkg/streamx/provider/ttstream/server_provider.go 45.45% 5 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1658      +/-   ##
===========================================
+ Coverage    57.39%   63.80%   +6.40%     
===========================================
  Files          408      379      -29     
  Lines        37693    34319    -3374     
===========================================
+ Hits         21633    21896     +263     
+ Misses       14738    11108    -3630     
+ Partials      1322     1315       -7
Flag Coverage Δ
integration 47.68% <83.13%> (+1.67%) ⬆️
unit 55.68% <35.36%> (+3.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie force-pushed the refactor/streamx-api branch from d0211d5 to 27f8a42 Compare February 17, 2025 03:44
DMwangnima
DMwangnima reviewed Mar 6, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 6, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 6, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 6, 2025
View reviewed changes
YangruiEmma
YangruiEmma reviewed Mar 6, 2025
View reviewed changes
YangruiEmma
YangruiEmma reviewed Mar 6, 2025
View reviewed changes
YangruiEmma
YangruiEmma reviewed Mar 6, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 7, 2025
View reviewed changes
@jayantxie jayantxie force-pushed the refactor/streamx-api branch from c05425c to 7b47916 Compare March 7, 2025 03:43
DMwangnima
DMwangnima reviewed Mar 7, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 7, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 7, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 7, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed Mar 7, 2025
View reviewed changes
@jayantxie jayantxie force-pushed the refactor/streamx-api branch from 535a3df to 2d27d78 Compare March 10, 2025 05:43
@jayantxie jayantxie merged commit efe7463 into cloudwego:develop Mar 10, 2025
22 checks passed
@jayantxie jayantxie changed the title refactor: stream api refactor: streamx api to adapt both grpc and ttheader streaming protocol and provide more user-friendly interface Mar 13, 2025
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayantxie @YangruiEmma @DMwangnima