optimize(retry): optimize UpdatePolicy and add test cases to check invalid retry policy #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaa39cb to
0f25202
Compare
…valid retry policy
0f25202 to
ad83cf0
Compare
jayantxie
previously approved these changes
Nov 19, 2024
ppzqh
reviewed
Nov 20, 2024
…valid retry policy
ppzqh
approved these changes
Nov 20, 2024
jayantxie
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
zh: optimize(retry): 优化 UpdatePolicy 并添加测试用例检查重试策略
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: <v0.11.0, if the FailurePolicy is nil and type is 0 or >1, will trigger nil panic. The bug has been fixed in v0.11.0, this pr is to add test cases and optimize �
UpdatePolicyto ignore the nil paniczh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: