perf(circuitbreak): no allocation for MW #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24ddd44 to
9eb6d0e
Compare
ppzqh
approved these changes
Oct 14, 2024
```
s.serviceCBConfig.LoadOrStore(serviceCBKey, defaultCBConfig)
```
`serviceCBKey` escapes due to any parameter
`defaultCBConfig` escapes due to passing struct to any parameter
goos: darwin
goarch: arm64
pkg: github.com/cloudwego/kitex/pkg/circuitbreak
│ ./old.txt │ ./new.txt │
│ sec/op │ sec/op vs base │
CBSuiteMW-12 95.53n ± 4% 70.98n ± 7% -25.69% (p=0.002 n=6)
│ ./old.txt │ ./new.txt │
│ B/op │ B/op vs base │
CBSuiteMW-12 40.00 ± 0% 0.00 ± 0% -100.00% (p=0.002 n=6)
│ ./old.txt │ ./new.txt │
│ allocs/op │ allocs/op vs base │
CBSuiteMW-12 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.002 n=6)
9eb6d0e to
5ae36e8
Compare
YangruiEmma
approved these changes
Oct 18, 2024
ppzqh
pushed a commit
to ppzqh/kitex
that referenced
this pull request
Nov 25, 2024
s.serviceCBConfig.LoadOrStore(serviceCBKey, defaultCBConfig)
serviceCBKey escapes due to any parameter
defaultCBConfig escapes due to passing struct to any parameter
goos: darwin
goarch: arm64
pkg: github.com/cloudwego/kitex/pkg/circuitbreak
│ ./old.txt │ ./new.txt │
│ sec/op │ sec/op vs base │
CBSuiteMW-12 95.53n ± 4% 70.98n ± 7% -25.69% (p=0.002 n=6)
│ ./old.txt │ ./new.txt │
│ B/op │ B/op vs base │
CBSuiteMW-12 40.00 ± 0% 0.00 ± 0% -100.00% (p=0.002 n=6)
│ ./old.txt │ ./new.txt │
│ allocs/op │ allocs/op vs base │
CBSuiteMW-12 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.002 n=6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serviceCBKeyescapes due to any parameterdefaultCBConfigescapes due to passing struct to any parameterWhat type of PR is this?
perf
Check the PR title.
(Optional) Translate the PR title into Chinese.
perf(circuitbreak): 无对象分配
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: