Skip to content

perf(rpcinfo): rm lock for rpcStats #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Sep 19, 2024

  • use atomic for updating and retrieving events
  • use embedded events. No pool needed for rpcStats

What type of PR is this?

perf

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

优化rpcinfo 中的 rpcStats,去掉锁。

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners September 19, 2024 11:02
@xiaost xiaost requested review from YangruiEmma and ppzqh September 24, 2024 05:28
@xiaost xiaost force-pushed the perf/rpcinfo branch 2 times, most recently from 753d5d0 to e9569ea Compare September 26, 2024 17:59
YangruiEmma
YangruiEmma previously approved these changes Sep 27, 2024
* use atomic for updating and retrieving events
* use embedded events. No pool needed for rpcStats
@xiaost xiaost merged commit 4943f34 into cloudwego:develop Sep 27, 2024
19 checks passed
@xiaost xiaost deleted the perf/rpcinfo branch September 27, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants