Skip to content

refactor(codec/thrift): unified typecodec & new file layout #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

refactor(codec/thrift): unified typecodec & new file layout #1553

merged 1 commit into from
Sep 24, 2024

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Sep 17, 2024 •
edited
Loading

  • fastcodec functions are in codec_fast.go
  • frugal functions are in codec_frugal.go
  • apache thrift functions are in codec_apache.go
  • added typeCodec and cached it, see codec.go

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

统一 type codec 实现，调整文件布局。

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners September 17, 2024 14:01
@xiaost xiaost force-pushed the refactor-codec branch 3 times, most recently from e8a6f04 to 4804311 Compare September 17, 2024 14:46
@xiaost xiaost merged commit 1d2ad87 into cloudwego:develop Sep 24, 2024
20 checks passed
@xiaost xiaost deleted the refactor-codec branch September 24, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@jayantxie jayantxie jayantxie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaost @YangruiEmma @jayantxie