feat(generic): support an option to set ParseMode for each client #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5ed206 to
1cc6cb3
Compare
AsterDY
reviewed
Sep 9, 2024
jayantxie
reviewed
Sep 10, 2024
jayantxie
reviewed
Sep 10, 2024
1c0d78e to
8bd67c8
Compare
AsterDY
approved these changes
Sep 11, 2024
jayantxie
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
In the past, the parse mode could only be set through env variable, but with generic.WithParseMode(parseMode) option, it is now possible to specify ParseMode for each generic client/server individually.
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: