feat(generic): support an option to remove go.tag annotation #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsterDY
previously approved these changes
Sep 3, 2024
f680bdd to
f467917
Compare
cdcb1aa to
91f0141
Compare
AsterDY
reviewed
Sep 23, 2024
jayantxie
reviewed
Sep 23, 2024
jayantxie
reviewed
Sep 23, 2024
jayantxie
reviewed
Sep 23, 2024
91f0141 to
4f0f2e2
Compare
jayantxie
reviewed
Oct 8, 2024
jayantxie
reviewed
Oct 8, 2024
jayantxie
previously approved these changes
Oct 8, 2024
AsterDY
reviewed
Oct 8, 2024
AsterDY
approved these changes
Oct 9, 2024
jayantxie
approved these changes
Oct 9, 2024
Marina-Sakai
added a commit
to Marina-Sakai/kitex
that referenced
this pull request
Nov 18, 2024
Marina-Sakai
added a commit
to Marina-Sakai/kitex
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
Previously, go.tag annotation could be disabled only by env variable. Now, generic.WithGoTagDisabled(true) option can disable go.tag annotation for each generic client/server respectively.
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: