Skip to content

feat(generic): support thrift streaming for json generic client #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Nov 18, 2024
Merged

feat(generic): support thrift streaming for json generic client #1467

merged 26 commits into from
Nov 18, 2024

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners July 31, 2024 03:26
@Marina-Sakai Marina-Sakai changed the title feat(generic): support thrift json streaming generic client WIP: feat(generic): support thrift json streaming generic client Jul 31, 2024
@Marina-Sakai Marina-Sakai changed the title WIP: feat(generic): support thrift json streaming generic client feat(generic): support thrift json streaming generic client Jul 31, 2024
@Marina-Sakai Marina-Sakai changed the title feat(generic): support thrift json streaming generic client feat(generic): support thrift streaming for json generic client Aug 1, 2024
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch 3 times, most recently from f07ad27 to ae91d13 Compare August 7, 2024 10:03
@Marina-Sakai Marina-Sakai changed the title feat(generic): support thrift streaming for json generic client [WIP] feat(generic): support thrift streaming for json generic client Aug 22, 2024
@Marina-Sakai Marina-Sakai changed the title [WIP] feat(generic): support thrift streaming for json generic client WIP: feat(generic): support thrift streaming for json generic client Aug 22, 2024
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch from ae91d13 to 1a40333 Compare August 26, 2024 10:05
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch from 0518592 to d6ce1ac Compare November 1, 2024 08:33
Marina-Sakai
Marina-Sakai commented Nov 1, 2024
View reviewed changes
@Marina-Sakai Marina-Sakai changed the title WIP: feat(generic): support thrift streaming for json generic client feat(generic): support thrift streaming for json generic client Nov 1, 2024
AsterDY
AsterDY previously approved these changes Nov 1, 2024
View reviewed changes
AsterDY
AsterDY previously approved these changes Nov 3, 2024
View reviewed changes
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch from 6e888c3 to 36e46ff Compare November 4, 2024 08:13
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch from 36e46ff to 68fe0ef Compare November 8, 2024 08:27
Marina-Sakai
Marina-Sakai commented Nov 13, 2024
View reviewed changes
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch 2 times, most recently from 0f673cb to 1f75b8f Compare November 14, 2024 08:12
jayantxie
jayantxie previously approved these changes Nov 15, 2024
View reviewed changes
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch from 484d445 to ee2711f Compare November 18, 2024 01:21
AsterDY
AsterDY reviewed Nov 18, 2024
View reviewed changes
jayantxie
jayantxie previously approved these changes Nov 18, 2024
View reviewed changes
@Marina-Sakai
refactor: replace base with gopkg base
a934c58
@Marina-Sakai
fix: import
60d8ff8
@Marina-Sakai
refactor: remove apache tprotocol from generic
0b51948
@Marina-Sakai
chore: define mtInfo
b3aa214
@Marina-Sakai
test: add tests for json thrift generic streaming
2efa5ae
@Marina-Sakai
feat: support json thrift generic streaming writer reader
f8c0b21
@Marina-Sakai
chore: delete unnecessary comments
6ce5521
@Marina-Sakai
fix: lisence
23882b6
@Marina-Sakai
chore: delete unnecessary file
20e8754
@Marina-Sakai
chore: delete unnecessary change
9401983
@Marina-Sakai
chore: remove go116plus
2bfcbd5
@Marina-Sakai
fix: copy
b7692a3
@Marina-Sakai
refactor: remove genericWriter/Reader
da65a0a
@Marina-Sakai
refactor: generic args/result
7c09eb8
@Marina-Sakai
fix: import
0c5ecda
@Marina-Sakai
feat: unwrap struct for streaming type descriptor
872577f
@Marina-Sakai
fix: the structure of function descriptor
725a31e
@Marina-Sakai
fix: rename
dc62315
@Marina-Sakai
chore: update dynamicgo
4a72540
@Marina-Sakai
chore: not expose apis
600fb16
@Marina-Sakai
fix: make sonic compatible with jsoniter
767e232
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_json_streaming_generic_client branch from 4b619fc to 767e232 Compare November 18, 2024 03:34
@Marina-Sakai Marina-Sakai merged commit 8e9df9a into cloudwego:develop Nov 18, 2024
19 checks passed
Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Nov 18, 2024
@Marina-Sakai
feat(generic): support thrift streaming for json generic client (clou…
287af33 
…dwego#1467)
@Marina-Sakai Marina-Sakai deleted the feat/thrift_json_streaming_generic_client branch November 18, 2024 08:34
DMwangnima pushed a commit that referenced this pull request Nov 27, 2024
@Marina-Sakai @DMwangnima
feat(generic): support thrift streaming for json generic client (#1467)
654372f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsterDY AsterDY AsterDY approved these changes

@jayantxie jayantxie jayantxie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marina-Sakai @AsterDY @jayantxie