Skip to content

fix(resp): ChunkedBodyWriter skip zero-len buf #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Jun 16, 2025

Fixes #1379

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost marked this pull request as ready for review June 16, 2025 05:40
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (5480721) to head (ef7553c).

Files with missing lines Patch % Lines
pkg/protocol/http1/resp/writer.go 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1380      +/-   ##
===========================================
+ Coverage    73.98%   74.01%   +0.03%     
===========================================
  Files          145      145              
  Lines        16930    16938       +8     
===========================================
+ Hits         12525    12537      +12     
+ Misses        3807     3805       -2     
+ Partials       598      596       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost merged commit f64adc2 into develop Jun 18, 2025
29 checks passed
@xiaost xiaost deleted the fix/chunk-writer branch June 18, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

gqlgen playground handler adaptor HertzHandler Err 257
4 participants