Skip to content

fix(sse): better compatibility with '\r' #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

fix(sse): better compatibility with '\r' #1374

merged 2 commits into from
Jun 10, 2025

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Jun 9, 2025

Fixes #1373

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (4cb5118) to head (13489bf).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1374   +/-   ##
========================================
  Coverage    74.01%   74.02%           
========================================
  Files          145      145           
  Lines        16909    16930   +21     
========================================
+ Hits         12515    12532   +17     
- Misses        3800     3803    +3     
- Partials       594      595    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost marked this pull request as ready for review June 9, 2025 08:29
@xiaost xiaost requested review from a team as code owners June 9, 2025 08:29
DMwangnima
DMwangnima previously approved these changes Jun 9, 2025
View reviewed changes
@xiaost xiaost merged commit 3f11f71 into develop Jun 10, 2025
49 of 61 checks passed
@xiaost xiaost deleted the fix/sse-cr-eol branch June 10, 2025 06:31
@alimy alimy mentioned this pull request Jun 11, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSE Reader未支持完整文法
3 participants
@xiaost @YangruiEmma @DMwangnima