Skip to content

fix(client): set timeout for tls handshake #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

fix(client): set timeout for tls handshake #1368

merged 3 commits into from
Jun 3, 2025
+284 −117

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented May 29, 2025 •
edited
Loading

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost force-pushed the refactor/request-timeout branch 2 times, most recently from 6cc1cbf to b76122b Compare May 29, 2025 09:44
@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.23256% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.98%. Comparing base (47fff9b) to head (5442a7e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/common/test/mock/network.go 36.84% 11 Missing and 1 partial ⚠️
pkg/protocol/http1/client.go 92.53% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1368      +/-   ##
===========================================
- Coverage    74.00%   73.98%   -0.02%     
===========================================
  Files          145      145              
  Lines        16878    16906      +28     
===========================================
+ Hits         12490    12508      +18     
- Misses        3794     3803       +9     
- Partials       594      595       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost marked this pull request as ready for review May 29, 2025 09:45
@xiaost xiaost requested review from a team as code owners May 29, 2025 09:45
@xiaost xiaost force-pushed the refactor/request-timeout branch 2 times, most recently from 8748a1d to 8c7ce41 Compare May 29, 2025 10:07
jayantxie
jayantxie reviewed Jun 3, 2025
View reviewed changes
@xiaost xiaost force-pushed the refactor/request-timeout branch from 8c7ce41 to 7e983df Compare June 3, 2025 08:51
@xiaost xiaost changed the title refactor: optimized timeout for tls fix(client): set timeout for tls handshake Jun 3, 2025
@xiaost xiaost force-pushed the refactor/request-timeout branch from 7e983df to 1bac6f3 Compare June 3, 2025 08:57
@xiaost xiaost merged commit c0dc541 into develop Jun 3, 2025
29 checks passed
@xiaost xiaost deleted the refactor/request-timeout branch June 3, 2025 10:43
@xiaost
Copy link
Contributor Author

xiaost commented Jun 4, 2025

Closes #1366 #1367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@ppzqh ppzqh ppzqh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaost @jayantxie @ppzqh