Skip to content

fix: indefinite blocking if handshaking tls under unconnectable network #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: indefinite blocking if handshaking tls under unconnectable network #1367

wants to merge 1 commit into from

Conversation

jayantxie
Copy link
Member

@jayantxie jayantxie commented May 28, 2025 •
edited
Loading

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix: 修复未连通网络下 tls 握手无限等待问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

#1366

(Optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners May 28, 2025 09:18
@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (5513927) to head (cc9396e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/network/standard/connection.go 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1367      +/-   ##
===========================================
- Coverage    73.68%   73.65%   -0.04%     
===========================================
  Files          145      145              
  Lines        16860    16870      +10     
===========================================
+ Hits         12423    12425       +2     
- Misses        3848     3855       +7     
- Partials       589      590       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie force-pushed the fix/tls_indefinite_blocking branch from e3f8ae7 to cc9396e Compare May 28, 2025 09:20
HeyJavaBean
HeyJavaBean reviewed May 28, 2025
View reviewed changes
@xiaost xiaost mentioned this pull request Jun 4, 2025
Merged
3 tasks
@xiaost xiaost closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayantxie @HeyJavaBean @xiaost