Skip to content

feat(sse): reader supports cancel stream #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

feat(sse): reader supports cancel stream #1343

merged 2 commits into from
May 13, 2025

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Apr 29, 2025

Also:

  • ChunkedBodyWriter now respect io.Writer
  • ChunkedBodyWriter returns err if it's finalized

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: reader supports cancel stream
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.10072% with 36 lines in your changes missing coverage. Please review.

Project coverage is 73.50%. Comparing base (a0260d2) to head (1a134d1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/common/test/mock/network.go 0.00% 17 Missing ⚠️
pkg/protocol/http1/resp/response.go 55.55% 8 Missing ⚠️
pkg/protocol/http1/resp/writer.go 87.50% 3 Missing and 2 partials ⚠️
pkg/protocol/http1/ext/common.go 80.00% 1 Missing and 2 partials ⚠️
pkg/protocol/sse/reader.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1343      +/-   ##
===========================================
+ Coverage    73.45%   73.50%   +0.04%     
===========================================
  Files          144      144              
  Lines        16580    16654      +74     
===========================================
+ Hits         12179    12241      +62     
- Misses        3813     3829      +16     
+ Partials       588      584       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost marked this pull request as ready for review April 29, 2025 10:41
@xiaost xiaost requested review from a team as code owners April 29, 2025 10:41
@xiaost
feat(sse): reader supports cancel stream
b41713c 
Also:
* ChunkedBodyWriter now respect io.Writer
* ChunkedBodyWriter returns err if it's finalized
@xiaost xiaost force-pushed the feat-sse-cancel branch from 5c3f741 to b41713c Compare May 13, 2025 05:47
@xiaost xiaost force-pushed the feat-sse-cancel branch from a34c71e to 1a134d1 Compare May 13, 2025 05:54
@xiaost xiaost merged commit 3952e95 into develop May 13, 2025
29 checks passed
@xiaost xiaost deleted the feat-sse-cancel branch May 13, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@ppzqh ppzqh ppzqh approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaost @YangruiEmma @ppzqh @DMwangnima