Skip to content

feat(sse): add LastEventID helpers #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

feat(sse): add LastEventID helpers #1339

merged 1 commit into from
Apr 24, 2025

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Apr 24, 2025 •
edited
Loading

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: add LastEventID helper funcs
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (5a39ca9) to head (842a545).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/protocol/sse/reader.go 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1339      +/-   ##
===========================================
+ Coverage    73.42%   73.43%   +0.01%     
===========================================
  Files          144      144              
  Lines        16560    16569       +9     
===========================================
+ Hits         12159    12168       +9     
  Misses        3813     3813              
  Partials       588      588

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost marked this pull request as ready for review April 24, 2025 08:53
@xiaost xiaost requested review from a team as code owners April 24, 2025 08:53
@xiaost xiaost merged commit cf38573 into develop Apr 24, 2025
29 checks passed
@xiaost xiaost deleted the feat-sse-lastevent branch April 24, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaost @YangruiEmma @DMwangnima