fix(server): Shutdown checks ExitWaitTimeout #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure `Shutdown` will not block longer that `ExitWaitTimeout`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1332 +/- ##
===========================================
+ Coverage 72.80% 72.81% +0.01%
===========================================
Files 139 139
Lines 16244 16245 +1
===========================================
+ Hits 11826 11829 +3
+ Misses 3823 3821 -2
Partials 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
YangruiEmma
approved these changes
Apr 14, 2025
ppzqh
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: make sure
Shutdownwill not block longer thatExitWaitTimeoutzh(optional):
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: