Skip to content

fix(client): stream body for sse instead of timeout #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

fix(client): stream body for sse instead of timeout #1329

merged 1 commit into from
Apr 15, 2025

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Apr 11, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.26%. Comparing base (67fe3c7) to head (ba38fa3).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/protocol/http1/resp/response.go 92.00% 0 Missing and 2 partials ⚠️
pkg/protocol/client/client.go 0.00% 1 Missing ⚠️
pkg/protocol/request.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1329      +/-   ##
===========================================
+ Coverage    72.80%   73.26%   +0.46%     
===========================================
  Files          139      139              
  Lines        16244    16427     +183     
===========================================
+ Hits         11826    12035     +209     
+ Misses        3823     3798      -25     
+ Partials       595      594       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost marked this pull request as ready for review April 11, 2025 10:24
@xiaost xiaost requested review from a team as code owners April 11, 2025 10:24
@xiaost xiaost force-pushed the fix-sse branch 3 times, most recently from a8a0dba to 4f26810 Compare April 11, 2025 11:43
@xiaost xiaost merged commit a4cc1c5 into develop Apr 15, 2025
28 checks passed
@xiaost xiaost deleted the fix-sse branch April 15, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaost @YangruiEmma @DMwangnima