Skip to content

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Apr 9, 2025

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

新的 HertzHandler 用于兼容 net/http.Handler

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 73.68%. Comparing base (d3c6846) to head (3cbc1ee).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/common/adaptor/handler.go 90.62% 9 Missing and 3 partials ⚠️
pkg/common/adaptor/utils.go 89.23% 5 Missing and 2 partials ⚠️
internal/testutils/testutils.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1327      +/-   ##
===========================================
+ Coverage    73.52%   73.68%   +0.15%     
===========================================
  Files          143      145       +2     
  Lines        16656    16856     +200     
===========================================
+ Hits         12247    12420     +173     
- Misses        3826     3845      +19     
- Partials       583      591       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 359 files.

Valid Invalid Ignored Fixed
354 3 2 0
Click to see the invalid file list
  • pkg/common/adaptor/handler.go
  • pkg/common/adaptor/handler_test.go
  • pkg/common/adaptor/utils.go

@xiaost xiaost force-pushed the feat-adapt-http-handler branch 3 times, most recently from f1576d0 to 57f2c98 Compare April 10, 2025 10:00
@xiaost xiaost changed the title wip: feat(adaptor): new HertzHandler for net/http.Handler feat(adaptor): new HertzHandler for net/http.Handler Apr 10, 2025
@xiaost xiaost changed the title feat(adaptor): new HertzHandler for net/http.Handler feat(adaptor): new HertzHandler for http.Handler Apr 10, 2025
@xiaost xiaost force-pushed the feat-adapt-http-handler branch from 57f2c98 to 3287e3c Compare April 10, 2025 10:12
@xiaost xiaost marked this pull request as ready for review April 10, 2025 10:26
@xiaost xiaost requested review from a team as code owners April 10, 2025 10:26
@xiaost xiaost marked this pull request as draft April 10, 2025 10:30
@xiaost xiaost marked this pull request as ready for review April 10, 2025 10:30
@xiaost xiaost force-pushed the feat-adapt-http-handler branch from 3287e3c to 8818757 Compare April 11, 2025 08:31
@xiaost xiaost force-pushed the feat-adapt-http-handler branch 6 times, most recently from c5b5eda to 2c414e2 Compare April 25, 2025 09:10
@xiaost xiaost force-pushed the feat-adapt-http-handler branch 3 times, most recently from f5f9794 to 75e9108 Compare May 13, 2025 05:27
@xiaost xiaost force-pushed the feat-adapt-http-handler branch from 75e9108 to 3cbc1ee Compare May 14, 2025 05:31
@xiaost xiaost merged commit a0a327a into develop May 14, 2025
29 checks passed
@xiaost xiaost deleted the feat-adapt-http-handler branch May 14, 2025 05:36
@xiaost xiaost mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants