fix(protocol): header safe for concurrent reading #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
787d1dc to
64dcb4c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1321 +/- ##
===========================================
+ Coverage 72.78% 72.80% +0.02%
===========================================
Files 139 139
Lines 16242 16244 +2
===========================================
+ Hits 11821 11826 +5
+ Misses 3824 3823 -1
+ Partials 597 595 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
``` b := []byte(key) // <--- ([]byte)(key) does not escape utils.NormalizeHeaderKey(b, false) return h.peek(bytesconv.B2s(b)) ``` actually there is no need to reuse a buf for normalizing key ...
64dcb4c to
10a7166
Compare
YangruiEmma
approved these changes
Apr 7, 2025
AsterDY
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually there is no need to reuse a buf for normalizing key ...
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
修复 Header 对于 Peek 方法不是并发安全的问题
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: