Skip to content

fix(protocol): Peek() returns non-nil if key exists #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Apr 1, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复 Peek 对于 key 存在时,仍返回 nil 的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners April 1, 2025 06:39
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.79%. Comparing base (aeb2ae5) to head (b8dd7bf).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1317      +/-   ##
===========================================
+ Coverage    72.76%   72.79%   +0.02%     
===========================================
  Files          139      139              
  Lines        16239    16242       +3     
===========================================
+ Hits         11817    11824       +7     
+ Misses        3825     3823       -2     
+ Partials       597      595       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost force-pushed the fix-peek branch 2 times, most recently from 4802050 to 6079dc5 Compare April 1, 2025 06:53
@YangruiEmma YangruiEmma merged commit 456a707 into develop Apr 1, 2025
28 checks passed
@YangruiEmma YangruiEmma deleted the fix-peek branch April 1, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants