Skip to content

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Mar 14, 2025

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners March 14, 2025 09:26
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 355 files.

Valid Invalid Ignored Fixed
351 2 2 0
Click to see the invalid file list
  • internal/testutils/testutils.go
  • internal/testutils/testutils_test.go

@xiaost xiaost force-pushed the test-use-random-port branch from 480c199 to b067e8f Compare March 14, 2025 09:56
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (bee9460) to head (f9613ef).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/testutils/testutils.go 93.47% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1300      +/-   ##
===========================================
+ Coverage    72.32%   72.38%   +0.05%     
===========================================
  Files          138      139       +1     
  Lines        16185    16231      +46     
===========================================
+ Hits         11705    11748      +43     
- Misses        3885     3888       +3     
  Partials       595      595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost force-pushed the test-use-random-port branch 3 times, most recently from f565824 to 45d5ab0 Compare March 14, 2025 10:25
Marina-Sakai
Marina-Sakai previously approved these changes Mar 17, 2025
@xiaost xiaost merged commit 9fa0342 into develop Mar 18, 2025
32 checks passed
@xiaost xiaost deleted the test-use-random-port branch March 18, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants