Skip to content

test(route): faster & better coverage for engine shutdown #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

test(route): faster & better coverage for engine shutdown #1296

merged 1 commit into from
Mar 13, 2025

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Mar 13, 2025

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners March 13, 2025 07:33
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (d0d9e25) to head (9672cf0).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1296   +/-   ##
========================================
  Coverage    72.22%   72.23%           
========================================
  Files          138      138           
  Lines        16137    16137           
========================================
+ Hits         11655    11656    +1     
+ Misses        3887     3886    -1     
  Partials       595      595

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost force-pushed the test-route-engine branch from 0cc438e to 9672cf0 Compare March 13, 2025 07:38
@xiaost xiaost merged commit 4fce261 into develop Mar 13, 2025
43 of 44 checks passed
@xiaost xiaost deleted the test-route-engine branch March 13, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

+1 more reviewer

@Marina-Sakai Marina-Sakai Marina-Sakai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaost @YangruiEmma @Marina-Sakai