fix: compare body.Cap()
with maxKeepBodySize
instead of body.Len()
#1294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: hertz use http-body-slice's length to compare with
MaxKeepBodySize
to decide if keep it in request/response or put intorequestBodyPool
onResetBody()
.However, a big request body (
.Len()>MaxKeepBodySize
) which was firstly put intorequestBodyPool
is still likely to be used in subsequent request, even if the actually request data is small..therefore, once the subsequent request finish and back to
ResetBody()
logic, although its body's Cap is much larger than Len, it will still be kept in request/repsponse, which may introduce memory leak.zh(optional): 将
MaxKeepBody
的判定条件由Len()
改成Cap()
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: