Skip to content

chore(server): fix comment for server SIGTERM handling #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

chore

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Corrected a comment I forgot to modify in this PR
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners March 3, 2025 02:51
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.20%. Comparing base (7e5e773) to head (24605ec).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1286   +/-   ##
========================================
  Coverage    72.20%   72.20%           
========================================
  Files          138      138           
  Lines        16137    16137           
========================================
  Hits         11652    11652           
  Misses        3890     3890           
  Partials       595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marina-Sakai Marina-Sakai merged commit d68c1b2 into cloudwego:develop Mar 3, 2025
17 checks passed
@Marina-Sakai Marina-Sakai deleted the chore/fix_comment branch March 3, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants