Skip to content

optimize(server): exit normally when getting SIGTERM #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

optimize(server): exit normally when getting SIGTERM #1280

merged 1 commit into from
Feb 25, 2025

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners February 25, 2025 03:27
@Marina-Sakai Marina-Sakai changed the title WIP: optimize(server): exit normally when getting SIGTERM optimize(server): exit normally when getting SIGTERM Feb 25, 2025
@Marina-Sakai Marina-Sakai merged commit 463ad91 into cloudwego:develop Feb 25, 2025
15 checks passed
@Marina-Sakai Marina-Sakai deleted the opt/signal branch February 25, 2025 07:13
@kingcanfish
Copy link
Contributor 

// Default implementation for signal waiter.
// SIGTERM triggers immediately close.
// SIGHUP|SIGINT triggers graceful shutdown.

Maybe this comment should be modified accordingly.

@Marina-Sakai Marina-Sakai mentioned this pull request Mar 3, 2025
Merged
3 tasks
@Marina-Sakai
Copy link
Contributor Author

@kingcanfish Done. Thank you for your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaost xiaost xiaost approved these changes

@welkeyever welkeyever welkeyever approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Marina-Sakai @kingcanfish @xiaost @welkeyever