Skip to content

fix(hz): thrift filename with dot #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Feb 11, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: thrift filename with dot
zh(optional): 修复 thrift 文件名带 "." 导致解析失败的问题

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners February 11, 2025 07:58
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (ea445e3) to head (9e75296).
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1275      +/-   ##
===========================================
- Coverage    82.58%   80.68%   -1.91%     
===========================================
  Files          124      138      +14     
  Lines        11491    13534    +2043     
===========================================
+ Hits          9490    10920    +1430     
- Misses        1428     1940     +512     
- Partials       573      674     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuangmingLuo
Copy link
Member

rebase 下 develop 吧, 落后了很多

@FGYFFFF FGYFFFF force-pushed the fix/filename_with_dot branch from 9e75296 to 486f330 Compare February 11, 2025 11:39
@FGYFFFF FGYFFFF merged commit 4c26262 into cloudwego:develop Feb 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants