Skip to content

fix(binding): BindXXX with default value #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

fix(binding): BindXXX with default value #1222

merged 1 commit into from
May 21, 2025

Conversation

StounhandJ
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(Fix of setting the default value in a query request): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Fix of setting the default value in a query request
zh(optional):

(Optional) Which issue(s) this PR fixes:

When Binding the structure shown below, the default value is not set for a json and query type request. This fix fixes this for a query type query.

type List struct {
	Limit  int `json:"limit" query:"limit" validate:"omitempty,min=1,max=100" default:"50"`
	Offset int `json:"offset" query:"offset" validate:"omitempty,min=0" default:"0"`
}

(Optional) The PR that updates user documentation:

@StounhandJ StounhandJ requested review from a team as code owners October 30, 2024 18:31
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.68%. Comparing base (3835def) to head (5c39bd9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/app/server/binding/internal/decoder/tag.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1222      +/-   ##
===========================================
- Coverage    73.70%   73.68%   -0.02%     
===========================================
  Files          145      145              
  Lines        16856    16860       +4     
===========================================
  Hits         12423    12423              
- Misses        3844     3848       +4     
  Partials       589      589

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost changed the title fix: Set default value to TagInfo fix(binding): BindXXX with default value May 21, 2025
@xiaost xiaost merged commit faae220 into cloudwego:develop May 21, 2025
14 of 16 checks passed
@xiaost
Copy link
Contributor

xiaost commented May 21, 2025

@StounhandJ thanks for contribution. sorry for late reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaost xiaost xiaost approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StounhandJ @CLAassistant @xiaost @DMwangnima