feat: platform self-adaptation for file viewer application #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HFO4
reviewed
Jul 2, 2025
| {((expanded ? Object.values(ViewersByID) : selectorState?.viewers) ?? emptyViewer) | ||
| .filter((viewer) => { | ||
| const platform = viewer.platform || "all"; | ||
| return platform === "all" || platform === (isMobile ? "mobile" : "pc"); |
There was a problem hiding this comment.
Those filtered viewers are not excluded in https://github.com/cloudreve/frontend/blob/master/src/component/FileManager/ContextMenu/OpenWithMenuItems.tsx
Maybe you can do the filtering here:
frontend/src/redux/siteConfigSlice.ts
Line 71 in 2c56116
There was a problem hiding this comment.
isMobile based to useMediaQuery, it seems not suitable to be put into redux:
const theme = useTheme();
const isMobile = useMediaQuery(theme.breakpoints.down("sm"));
I haven't thought of a better way yet.
There was a problem hiding this comment.
You can get the client windows width easily in native JS.
There was a problem hiding this comment.
HFO4
reviewed
Jul 2, 2025
src/component/Admin/Settings/Filesystem/ViewerSetting/FileViewerEditDialog.tsx
Show resolved
Hide resolved
HFO4
approved these changes
Jul 3, 2025
|
Good job, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: cloudreve/cloudreve#2306