Add Kingsoft Cloud object storage policy to solve the cross-domain and friendly file name incompatibility problem of s3 compatible storage policy. #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks a lot! Will take a look in a few days. |
association frontend Pr: cloudreve/frontend#285 |
HFO4
requested changes
Jul 20, 2025
pkg/filemanager/driver/ks3/ks3.go
Outdated
| var contentDescription *string | ||
| if args.IsDownload { | ||
| encodedFilename := url.PathEscape(args.DisplayName) | ||
| contentDescription = aws.String(fmt.Sprintf(`attachment; filename="%s"`, |
There was a problem hiding this comment.
Looks like we need to remove the punctuation mark:
contentDescription = aws.String(fmt.Sprintf(`attachment; filename=%s`, encodedFilename))
pkg/filemanager/driver/ks3/ks3.go
Outdated
| HTTPMethod: s3.GET, // 请求方法 | ||
| Bucket: &handler.policy.BucketName, // 存储空间名称 | ||
| Key: aws.String(e.Source()), // 对象的key | ||
| Expires: 604800, // 过期时间，7 days |
pkg/filemanager/driver/ks3/ks3.go
Outdated
| ContentType: aws.String("application/octet-stream"), | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("生成分片%d预签名URL失败: %w", partNumber, err) |
There was a problem hiding this comment.
return fmt.Errorf("failed to generate presigned upload url for chunk %d: %w", partNumber, err)|
Codes have been corrected as required |
HFO4
reviewed
Jul 20, 2025
pkg/filemanager/driver/ks3/ks3.go
Outdated
| HTTPMethod: s3.GET, // 请求方法 | ||
| Bucket: &handler.policy.BucketName, // 存储空间名称 | ||
| Key: aws.String(e.Source()), // 对象的key | ||
| Expires: int64(time.Until(*args.Expire).Seconds()), // 过期时间，转换为秒数 |
There was a problem hiding this comment.
Please refer to https://github.com/cloudreve/cloudreve/blob/1cdccf5fc95aa7be432666e7f93ae95e02b61297/pkg/filemanager/driver/s3/s3.go#L309C2-L312C3
args.Expire might be nil, in which case default max TTL wil be used (7 days)
HFO4
approved these changes
Jul 21, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2642