Skip to content

support migration with proto descriptors file #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 16, 2025
Merged

support migration with proto descriptors file #145

merged 5 commits into from
Jun 16, 2025

Conversation

rail44
Copy link
Contributor

@rail44 rail44 commented Jun 4, 2025 •
edited
Loading

WHAT

  • Added --proto_descriptor_file flag to apply, create, load, and migrate up commands
  • Extended core Client methods to accept and handle proto descriptor data alongside DDL operations
  • Modified LoadDDL to return both schema and proto descriptors from existing databases
  • Added test for implemented features

WHY

Protocol buffer support is essential for Cloud Spanner applications using proto columns and message types. This feature enables users to:

  • Create and modify proto-enabled databases with proper message definitions
  • Migrate schemas that include proto column types
  • Load existing proto descriptors from databases for backup/export workflows
  • Maintain consistency between application proto definitions and database schema

@google-cla Google CLA
Copy link

google-cla bot commented Jun 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rail44 rail44 marked this pull request as ready for review June 4, 2025 14:24
@zchee
Copy link
Contributor

zchee commented Jun 4, 2025

cc: @vvakame @sinmetal

@sinmetal
Copy link
Collaborator

LGTM

@rail44 Thank you for your contribution.
I had a conflict when merging another PR, so could you please fix it?

@rail44
Copy link
Contributor Author

rail44 commented Jun 16, 2025 •
edited
Loading

@sinmetal
Thank you too for reviewing.
I've fixed conflict. I hope you will check again 🙏

@sinmetal sinmetal self-requested a review June 16, 2025 05:33
@sinmetal sinmetal merged commit 6563aca into cloudspannerecosystem:master Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinmetal sinmetal sinmetal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rail44 @zchee @sinmetal