Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudflare/tableflip
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.2.2
Choose a base ref
...
head repository: cloudflare/tableflip
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.2.3
Choose a head ref
  • 5 commits
  • 10 files changed
  • 4 contributors

Commits on Jan 25, 2021

  1. fix flaky TestFilesAreNonblocking on CI

    CI runs test with stdin closed, which leads our victim cat process
    to exit quickly. Depending on the ordering of events we might see
    the test fail. Change the contract for newOSProcess to include
    stdin, stdout and stderr and allocate a blocking pipe as stdin for
    the test.
    lmb committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    287e7a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. add function to return all inherited files

    This is helpful in the use case of integrating with systemd socket activation.
    
    When there is no parent, the app still need to scan or use actication.Files() to
    find all the fds and call upgrader.AddFile() to track them. But when there is a
    parent, we can access the fds from upgrader instance rather then by scanning
    fds or calling actication.Files() both of which creates os.File objects for the fds.
    
    Without this change, there would be two set of os.File objects that represent
    the same fd set. One set of os.File is hold by the upgrader whie the another set
    returning from fd scanning (or actication.Files()) is being used at other places.
    This raise a risk of closing the same fd twice at different time which is really bad
    when the fd get reused by other files during the two close calls.
    Hunts Chen authored and jdesgats committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    cd67dfb View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Fix workflow syntax when more than one file fail format check

    Previously the files were expanded to multiple arguments to `test`
    generating confusing error messages.
    jdesgats committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    a4d168b View commit details
    Browse the repository at this point in the history
  2. Add build constraints for the Go 1.16+ format

    This is reported by `gofmt`.
    jdesgats committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    7fb144b View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Update notes about the journald bug (#70)

    The bug has been fixed for about 2 years, let's be clear about it's state.
    hunts authored Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b3a0d54 View commit details
    Browse the repository at this point in the history
Loading