Skip to content

Replace deprecated go-metrics with prometheus #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cbroglie
Copy link
Contributor

This is a breaking change.

@cbroglie cbroglie changed the title chore(multirootca): replace deprecated go-metrics with prometheus Replace deprecated go-metrics with prometheus May 24, 2019
@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #1002 (a5a4bda) into master (6eb1640) will increase coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   54.66%   56.42%   +1.76%     
==========================================
  Files          77       77              
  Lines        6653     7170     +517     
==========================================
+ Hits         3637     4046     +409     
- Misses       2559     2665     +106     
- Partials      457      459       +2     
Impacted Files Coverage Δ
cli/gencert/gencert.go 73.68% <0.00%> (-3.65%) ⬇️
api/client/group.go 41.50% <0.00%> (-2.94%) ⬇️
cli/config.go 89.39% <0.00%> (-1.24%) ⬇️
cli/cli.go 31.57% <0.00%> (-0.73%) ⬇️
ocsp/ocsp.go 83.11% <0.00%> (-0.45%) ⬇️
certdb/ocspstapling/ocspstapling.go 51.78% <0.00%> (-0.07%) ⬇️
scan/pki.go 0.00% <0.00%> (ø)
scan/broad.go 0.00% <0.00%> (ø)
errors/http.go 100.00% <0.00%> (ø)
ubiquity/sha1.go 100.00% <0.00%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb1640...6306b3f. Read the comment docs.

@nickysemenza nickysemenza self-assigned this Mar 10, 2020
@nickysemenza
Copy link
Contributor

nickysemenza commented Feb 10, 2021

stale, will reopen (as #1174)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants