V8 Instance steps for multiple commands #3485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix error message for push command Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Display current step in the canary deployment Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Add --instance-steps to the restart command Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Add flag --instance-steps to restage command Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Add --instance-steps to rollback Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Add --instance-steps to copy-source command Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Fix rollback that was not setting the correct values on the deployment Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Add min capi version check on instance steps commands Signed-off-by: João Pereira <joao.pereira@broadcom.com> * Fix pointer reference * Add version to copy-source canary step test * Update canary step version requirement * Fix continue deployment test * Fix CAPI versions in tests * Fixes for canary integration tests * Fix flakey canary test * Add missing continue to copy-source canary test --------- Signed-off-by: João Pereira <joao.pereira@broadcom.com> Co-authored-by: Sam Gunaratne <385176+Samze@users.noreply.github.com> Co-authored-by: Sam Gunaratne <sgunaratne@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 version of #3400