Skip to content

Conversation

moleske
Copy link
Member

@moleske moleske commented Mar 19, 2025

  • v7 is no longer in support, so let's not waste resources on it

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main, v8 and v7) as needed.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

@moleske moleske requested review from a team March 19, 2025 02:13
@moleske
Copy link
Member Author

moleske commented Mar 19, 2025

This pr mostly exists to try and keep main branch and v8 branch in sync. The pr against main (#3459) is the one that really matters

@moleske
Copy link
Member Author

moleske commented Mar 20, 2025

Not clear why this is repeatedly failing on CATS. Don't quite have the time to investigate it, though it seems unrelated to the changes here. So maybe something bigger?

- v7 is no longer in support, so let's know waste resources on it
@a-b a-b force-pushed the remove-v7-from-github-actions-dependabot-v8 branch from 51a6a08 to 21d6359 Compare March 20, 2025 15:17
@a-b a-b merged commit 1d84041 into v8 Mar 20, 2025
12 of 13 checks passed
@a-b a-b deleted the remove-v7-from-github-actions-dependabot-v8 branch March 20, 2025 15:17
@a-b
Copy link
Member

a-b commented Mar 20, 2025

I don't know how much this change benefits us in terms of resource savings, as we are not pushing items to the v7 branch. At the same time, I appreciate the reduction of clutter and complexity.

@a-b
Copy link
Member

a-b commented Mar 20, 2025

This pr mostly exists to try and keep main branch and v8 branch in sync. The pr against main (#3459) is the one that really matters

We are thinking of consolidating v8 and main soon.

@moleske
Copy link
Member Author

moleske commented Mar 20, 2025

I don't know how much this change benefits us in terms of resource savings, as we are not pushing items to the v7 branch. At the same time, I appreciate the reduction of clutter and complexity.

At the very least, dependabot was running which clutters the prs and uses resources to try and run the pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants