Update runner image to the latest ubuntu #3450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
a-b
commented
Mar 11, 2025
- Use dpkg-deb -Zxz to keep backward compatibility
- Improve test to check compatibility with Deb OSes
- Use dpkg-deb -Zxz to keep backward compatibility - Improve test to check compatibility with Deb OSes Co-authored-by: João Pereira <joao.pereira@broadcom.com> Co-authored-by: Alex Rocha <alex.rocha@broadcom.com>
Samze
reviewed
Mar 11, 2025
| run: | | ||
| ls -R | ||
|
|
||
| for i in debian:11 debian:12 ubuntu:20.04 ubuntu:22.04 ubuntu; do docker run \ |
There was a problem hiding this comment.
question I dont have context on the compression issue, but how does this test it?
There was a problem hiding this comment.
dpkg --info fails when trying to open a .deb file with unsupported compression.
There was a problem hiding this comment.
Couple examples:
- red run with unsupported compression https://github.com/a-b/cli/actions/runs/13781247233/job/38539815075#step:3:30
- green run https://github.com/a-b/cli/actions/runs/13781160806/job/38539576483#step:3:29
There was a problem hiding this comment.
Can we use the matrix strategy here to change the container image? instead of this for loop?
There was a problem hiding this comment.
Good call. Yes, we should use matrix!
joaopapereira
approved these changes
Mar 11, 2025
| run: | | ||
| ls -R | ||
|
|
||
| for i in debian:11 debian:12 ubuntu:20.04 ubuntu:22.04 ubuntu; do docker run \ |
There was a problem hiding this comment.
Can we use the matrix strategy here to change the container image? instead of this for loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.