Skip to content

Fix failing test due to new auth flow #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix failing test due to new auth flow #3458

merged 1 commit into from
Mar 19, 2025

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Mar 18, 2025

No description provided.

@Samze
Copy link
Contributor Author

Samze commented Mar 18, 2025

Once verified this change will need to be ported to #3455

@Samze Samze mentioned this pull request Mar 18, 2025
Merged
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 18, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Samze / name: Sam Gunaratne (e9516f2)

@Samze Samze force-pushed the fix_auth_main branch 3 times, most recently from a8b100c to d980fb2 Compare March 19, 2025 02:12
@strehle
Copy link
Member

strehle commented Mar 19, 2025

@Samze I think you can merge this. I could / can not run these kind of tests, so sorry that I missed them before

xandroc
xandroc approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@xandroc xandroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

a-b
a-b approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b merged commit c424a04 into main Mar 19, 2025
13 checks passed
@a-b a-b deleted the fix_auth_main branch March 19, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b a-b a-b approved these changes

+2 more reviewers

@xandroc xandroc xandroc approved these changes

@strehle strehle strehle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Samze @strehle @a-b @xandroc