fix: consumeData(and consumeDataAsBytes) should consider structued mode JSON … #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embano1
reviewed
Jun 8, 2025
…content types also JSON Signed-off-by: Alan Kan <alan.kan@pepperstone.com>
Signed-off-by: Alan Kan <alan.kan@pepperstone.com>
|
Hi @embano1 , do you mind having another look? |
embano1
requested changes
Jun 12, 2025
v2/event/content_type.go
Outdated
| @@ -14,6 +14,20 @@ const ( | |||
| ApplicationCloudEventsBatchJSON = "application/cloudevents-batch+json" | |||
| ) | |||
|
|
|||
| type ContentType string | |||
There was a problem hiding this comment.
Hm, can we 1/ not export this and 2/ simplify this into just a simple function? See below.
v2/event/content_type.go
Outdated
| type ContentType string | ||
|
|
||
| // IsJSON returns true if the content type is a JSON type. | ||
| func (c ContentType) IsJSON() bool { |
There was a problem hiding this comment.
Instead of introducing an exported type, how about:
Suggested change
| func (c ContentType) IsJSON() bool { | |
| func isJSON(contentType string) bool { ... } |
There was a problem hiding this comment.
The unit test cannot access it then :(
There was a problem hiding this comment.
I can ditch the unit test if preferred
There was a problem hiding this comment.
@embano1 updated as suggested, thanks 🙇
Signed-off-by: Alan Kan <alan.kan@pepperstone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…content types also JSON
#1161