-
Notifications
You must be signed in to change notification settings - Fork 232
Fix failing CI tests #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CI tests #1156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok once signed
Thx Dug, there's more coming though - detected a bunch of stale/outdated Go modules in tests. Working on fixing them, but they haven't been touched in years so lots of broken/gone deps. |
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Update tests due to dependency updates Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@duglin bigger update, hopefully getting closer to automatically keeping our various (test) deps in sync on a weekly basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@embano1 thanks for all the work on this! Life isn't supposed to be this hard :-)
Hehehe, yeah, but then how can you enjoy the simple things in life if nothing is "hard" :) But I hear you. I think it's also because for a long time we haven't really done much on the automation side to keep all deps/tests in sync across the various modules and implementations we have. |
Dependency Updates and Conformance Test Fixes
Dependency Updates
• Updated golang.org/x/time from v0.0.0-20210723032227 to v0.11.0 across all
modules
• Updated golang.org/x/sync from v0.13.0 to v0.14.0
• Updated github.com/nats-io/nats.go from v1.41.2 to v1.42.0
• Updated sigs.k8s.io/yaml from v1.3.0 to v1.4.0
• Updated various crypto, net, and system packages to their latest versions
• Switched from github.com/Shopify/sarama to github.com/IBM/sarama v1.45.1 for
Kafka integration in benchmarks
• Updated golangci-lint-action from v7.0.0 to v8.0.0 with linter version from
v2.0 to v2.1.6
Conformance Test Fixes
• Fixed the conformance tests by updating the godog package from v0.9.0 to
v0.15.0
• Updated test implementations to use the newer godog API:
• Changed godog.Suite to godog.ScenarioContext
• Updated RunWithOptions to use TestSuite
• Fixed parameter types for tables and doc strings
• Improved HTTP request parsing to properly handle request bodies
Documentation Updates
• Updated protocol documentation to reflect the change from Shopify to IBM
Sarama package
Build System Improvements
• Enhanced the update-deps.sh script to include test dependencies with -t flag