Skip to content

Conversation

embano1
Copy link
Member

@embano1 embano1 commented May 7, 2025

Dependency Updates and Conformance Test Fixes

Dependency Updates

• Updated golang.org/x/time from v0.0.0-20210723032227 to v0.11.0 across all
modules
• Updated golang.org/x/sync from v0.13.0 to v0.14.0
• Updated github.com/nats-io/nats.go from v1.41.2 to v1.42.0
• Updated sigs.k8s.io/yaml from v1.3.0 to v1.4.0
• Updated various crypto, net, and system packages to their latest versions
• Switched from github.com/Shopify/sarama to github.com/IBM/sarama v1.45.1 for
Kafka integration in benchmarks
• Updated golangci-lint-action from v7.0.0 to v8.0.0 with linter version from
v2.0 to v2.1.6

Conformance Test Fixes

• Fixed the conformance tests by updating the godog package from v0.9.0 to
v0.15.0
• Updated test implementations to use the newer godog API:
• Changed godog.Suite to godog.ScenarioContext
• Updated RunWithOptions to use TestSuite
• Fixed parameter types for tables and doc strings
• Improved HTTP request parsing to properly handle request bodies

Documentation Updates

• Updated protocol documentation to reflect the change from Shopify to IBM
Sarama package

Build System Improvements

• Enhanced the update-deps.sh script to include test dependencies with -t flag

@embano1 embano1 requested a review from a team as a code owner May 7, 2025 04:36
duglin
duglin previously approved these changes May 7, 2025
Copy link
Contributor

@duglin duglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok once signed

@embano1
Copy link
Member Author

embano1 commented May 7, 2025

Thx Dug, there's more coming though - detected a bunch of stale/outdated Go modules in tests. Working on fixing them, but they haven't been touched in years so lots of broken/gone deps.

embano1 added 2 commits May 12, 2025 10:05
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
embano1 added 2 commits May 12, 2025 10:17
Update tests due to dependency updates

Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@embano1 embano1 marked this pull request as ready for review May 12, 2025 08:17
@embano1 embano1 enabled auto-merge May 12, 2025 08:17
@embano1
Copy link
Member Author

embano1 commented May 12, 2025

@duglin bigger update, hopefully getting closer to automatically keeping our various (test) deps in sync on a weekly basis.

Copy link
Contributor

@duglin duglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@embano1 thanks for all the work on this! Life isn't supposed to be this hard :-)

@embano1 embano1 merged commit d12b4e5 into cloudevents:main May 12, 2025
9 checks passed
@embano1 embano1 deleted the updates branch May 12, 2025 11:44
@embano1
Copy link
Member Author

embano1 commented May 12, 2025

@embano1 thanks for all the work on this! Life isn't supposed to be this hard :-)

Hehehe, yeah, but then how can you enjoy the simple things in life if nothing is "hard" :) But I hear you. I think it's also because for a long time we haven't really done much on the automation side to keep all deps/tests in sync across the various modules and implementations we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants