-
Notifications
You must be signed in to change notification settings - Fork 232
chore: update dependencies #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1209700
to
910cdd9
Compare
@duglin for your review - I had to manually force some version updates because they were still over the place with hardcoded versions the script ( |
test/sql/go.mod
Outdated
@@ -5,17 +5,16 @@ go 1.23.0 | |||
toolchain go1.23.8 | |||
|
|||
require ( | |||
github.com/cloudevents/sdk-go/sql/v2 v2.14.0 | |||
github.com/cloudevents/sdk-go/v2 v2.15.2 | |||
github.com/cloudevents/sdk-go/sql/v2 v2.15.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duglin FYI, either there was a breaking change or there's some other reason why I couldn't force the go toolchain to upgrade to v2.16.0
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore, fixed due to missing replace - man...that codebase :)
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
910cdd9
to
b25dc6d
Compare
@@ -6,10 +6,10 @@ toolchain go1.23.8 | |||
|
|||
replace github.com/cloudevents/sdk-go/v2 => ../../v2 | |||
|
|||
replace github.com/cloudevents/sdk-go/protocol/kafka_confluent/v2 => ../../protocol/kafka_confluent/v2 | |||
replace github.com/cloudevents/sdk-go/protocol/kafka_confluent/v2 => ./../../protocol/kafka_confluent/v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that you had to make this change but didn't have to change line 7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, you mean the "./" vs just ".." style? I think both work and consistently using ".." would be better to avoid confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, either is fine, I was just wondering why this one line was changed but not any other. I assumed the tooling forced you to change it... did you just pick on this one line for fun? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, here's another change: https://github.com/cloudevents/sdk-go/pull/1149/files#diff-59c1886a6ec95fc3ad4c2ec3c62df3369c489f66b10bf766e91d3cd73343fb7b
Granted, it's not consistently used across our various go.mod
files :/
This PR updates Go dependencies.
This is an automated PR created by the weekly dependency update workflow.