Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This PR updates Go dependencies.

This is an automated PR created by the weekly dependency update workflow.

@github-actions github-actions bot requested a review from a team as a code owner April 21, 2025 03:25
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 21, 2025
@embano1 embano1 force-pushed the automated-dependency-updates branch from 1209700 to 910cdd9 Compare April 21, 2025 08:29
@embano1 embano1 enabled auto-merge April 21, 2025 08:30
embano1
embano1 previously approved these changes Apr 21, 2025
@embano1
Copy link
Member

embano1 commented Apr 21, 2025

@duglin for your review - I had to manually force some version updates because they were still over the place with hardcoded versions the script (go get) wouldn't automatically update.

test/sql/go.mod Outdated
@@ -5,17 +5,16 @@ go 1.23.0
toolchain go1.23.8

require (
github.com/cloudevents/sdk-go/sql/v2 v2.14.0
github.com/cloudevents/sdk-go/v2 v2.15.2
github.com/cloudevents/sdk-go/sql/v2 v2.15.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duglin FYI, either there was a breaking change or there's some other reason why I couldn't force the go toolchain to upgrade to v2.16.0 here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore, fixed due to missing replace - man...that codebase :)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@embano1 embano1 force-pushed the automated-dependency-updates branch from 910cdd9 to b25dc6d Compare April 21, 2025 09:59
@@ -6,10 +6,10 @@ toolchain go1.23.8

replace github.com/cloudevents/sdk-go/v2 => ../../v2

replace github.com/cloudevents/sdk-go/protocol/kafka_confluent/v2 => ../../protocol/kafka_confluent/v2
replace github.com/cloudevents/sdk-go/protocol/kafka_confluent/v2 => ./../../protocol/kafka_confluent/v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that you had to make this change but didn't have to change line 7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you mean the "./" vs just ".." style? I think both work and consistently using ".." would be better to avoid confusion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, either is fine, I was just wondering why this one line was changed but not any other. I assumed the tooling forced you to change it... did you just pick on this one line for fun? ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, here's another change: https://github.com/cloudevents/sdk-go/pull/1149/files#diff-59c1886a6ec95fc3ad4c2ec3c62df3369c489f66b10bf766e91d3cd73343fb7b

Granted, it's not consistently used across our various go.mod files :/

@embano1 embano1 merged commit af48f74 into main Apr 21, 2025
9 checks passed
@embano1 embano1 deleted the automated-dependency-updates branch April 21, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants