-
Notifications
You must be signed in to change notification settings - Fork 233
Dependency Management Improvements #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ccacba5
to
6bc99ed
Compare
hack/update-deps.sh
Outdated
# Change to the directory | ||
pushd "$DIR" >/dev/null | ||
|
||
# disable go toolchain switching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, why do we need this?
If we're using the same go version for everything maybe we should add a script to check to make sure all go.mod files use the same version. Or am I missing something that would prevent that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, sorry I was still working on this :) PR is now ready for review. Couldn't fully test the new script yet because of the "limited" testing capabilities with Github Actions ;) We'll see after merge...
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Dependabot doesn't properly tidy Go dependencies across the repository and lacks customization options. We've replaced it with a custom script that correctly updates and tidies dependencies on a weekly schedule. Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Will this create a PR even if nothing has changed? |
Nope, the action is smart in many ways - no-op is the default. |
I did a dry run in my repo, worked like a charm. Just didn't test if there's a dep change and how the PR will look like. But I used the action in other repos before and worked well. |
Also: should make your life and relationship to Go dep management better 😜 |
Sure! Next you'll want me to believe in unicorns |
This PR replaces Dependabot with a custom dependency update workflow to better handle our multi-module repository structure.
Changes:
hack/update-deps.sh
) to automatically update Go dependencies across all modulesupdate-dependencies.yml
) that runs weekly to update dependencies and create PRsgo.mod
) to1.23.*
This change provides a more reliable and consistent approach to dependency management across our multi-module repository structure, ensuring all modules stay up-to-date with the latest security patches and improvements.