fix: skip dynamic blocks that iterate over an unknown #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the value of a dynamic block's `for_each` is unknown at parse time, treat it the same as a null value. Closes cloud-custodian#249
876114d to
6ae984a
Compare
JonZeolla
approved these changes
Jun 8, 2025
sontek
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value of a dynamic block's
for_eachis unknown at parse time, treat it the same as a null value.Without the changes in
converter.go, the additions totest_parse_dynamic_content()cause that test to crash and reproduce the error reported in #249.Closes #249