fix: preserve parent module context in references #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the parent module path when identifying references, otherwise we won't be able to match them later.
013fc62 to
af324f2
Compare
adapt changes from upstream
so we can seed it with c7n-left dependencies, layer an editable tfparse over top of it, and run tests.
sontek
reviewed
Jun 23, 2025
Use a custom function to produce a fully-qualified reference path instead of performing a string replace on the output of `reference.HumanReadable()`. This is probably a more stable way to track references inside modules.
7749390 to
5088f56
Compare
sontek
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the parent module path when identifying references, otherwise we'll skip those references when building references metadata blocks.
Drive-by: Make enough changes to the CI configuration so that c7n-left tests run, following the upstream switch to uv