Skip to content

Fix empty alias call #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

Fix empty alias call #2500

merged 3 commits into from
Mar 10, 2025

Conversation

NoahTheDuke
Copy link
Contributor

@NoahTheDuke NoahTheDuke commented Mar 10, 2025 •
edited
Loading

Please answer the following questions and leave the below in as part of your PR.

Closes #2499

@NoahTheDuke
Copy link
Contributor Author

This is not the first fix required because tag doesn't have a corresponding impl for nil. Should tag actually hold the fix? Something like (defn tag [expr] (when expr (node/tag expr)))?

@borkdude
Copy link
Member

I think so yes, it's been pretty annoying to hit that over and over :)

@borkdude borkdude merged commit 0f32a67 into clj-kondo:master Mar 10, 2025
9 checks passed
@borkdude
Copy link
Member

Thanks!

@NoahTheDuke NoahTheDuke deleted the nb/fix-empty-alias-call branch March 10, 2025 15:44
@yuhan0 yuhan0 mentioned this pull request Apr 2, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty alias call throws error
2 participants
@NoahTheDuke @borkdude