-
-
Notifications
You must be signed in to change notification settings - Fork 291
Add :unknown-ns-option linter #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll take a closer look tomorrow, but generally I've put all "syntax errors" under the |
I was gonna do |
Ah alright, I guess it makes sense then, perhaps better for people who are going to add their own options or so |
Can you add tests to see if the ignore hint properly works in case people are using custom additions to the ns form? |
In trying to add tests, I've run into a quirk I don't quite understand. When parsing the namespace declaration, |
Not sure, but if you want me to take a look and finish up the tests, I'd be open to that of course (and you'll still be a contributor of the PR git-wise of course). |
I've pushed my failing test, so go for it. |
Fixed via other PR |
Please answer the following questions and leave the below in as part of your PR.
I have read the Clojure etiquette and will respect it when communicating on this platform.
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.
Closes #2473