Skip to content

Conversation

NoahTheDuke
Copy link
Contributor

Please answer the following questions and leave the below in as part of your PR.

Closes #2473

@borkdude
Copy link
Member

I'll take a closer look tomorrow, but generally I've put all "syntax errors" under the :syntax linter, might make sense here too?

@NoahTheDuke
Copy link
Contributor Author

I was gonna do :syntax but I saw that there's :unknown-require-option. I can switch to :syntax if you'd prefer.

@borkdude
Copy link
Member

Ah alright, I guess it makes sense then, perhaps better for people who are going to add their own options or so

@borkdude
Copy link
Member

Can you add tests to see if the ignore hint properly works in case people are using custom additions to the ns form?

@NoahTheDuke
Copy link
Contributor Author

In trying to add tests, I've run into a quirk I don't quite understand. When parsing the namespace declaration, ^:clj-kondo/ignore and other metadata are in :meta on the nodes, not in the meta of the node. Is this due to lift-meta-context not being called on it or something?

@borkdude
Copy link
Member

Not sure, but if you want me to take a look and finish up the tests, I'd be open to that of course (and you'll still be a contributor of the PR git-wise of course).

@NoahTheDuke
Copy link
Contributor Author

I've pushed my failing test, so go for it.

@borkdude
Copy link
Member

borkdude commented Feb 7, 2025

Fixed via other PR

@borkdude borkdude closed this Feb 7, 2025
@NoahTheDuke NoahTheDuke deleted the nb/unknown-ns-option branch February 7, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch between spec for (ns) and clj-kondo linting
2 participants