Skip to content

Conversation

arafatkatze
Copy link
Contributor

@arafatkatze arafatkatze commented Aug 7, 2025

Followup to #5379

Description

This PR just force switches all telemetry to use ULID instead of UUID. Since UUID has been in prod for such a short time we can either keep it as it is right now or we can force move to ULID and then that becomes the standard for now. Since its been a short while I am just doing a force move to this without any migration.

Test Procedure

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes


Important

Switch from UUID to ULID for task identification across the codebase, affecting telemetry, task management, and error handling.

  • Behavior:
    • Switch from uuid to ulid for task identification in ToolExecutor.ts, index.ts, and TelemetryService.ts.
    • Remove uuid package and add ulid package in package.json.
  • Telemetry:
    • Update telemetry functions in TelemetryService.ts to use ulid instead of uuid.
  • Task Management:
    • Replace uuid with ulid for task IDs in Task class in index.ts and ToolExecutor class in ToolExecutor.ts.
  • Misc:
    • Update HistoryItem type in HistoryItem.ts to use ulid instead of uuid.

This description was created by Ellipsis for 27c83c8. You can customize this summary. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: 27c83c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arafatkatze arafatkatze force-pushed the arafatkatze/switch-to-ulid branch from 214a7cf to d17d141 Compare August 7, 2025 00:57
@arafatkatze arafatkatze force-pushed the arafatkatze/switch-to-ulid branch from ef7aed6 to 96594ef Compare August 7, 2025 02:21
@arafatkatze arafatkatze marked this pull request as ready for review August 7, 2025 02:25
@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 02:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces UUID with ULID for task tracking in telemetry, implementing a breaking change to standardize on ULID for better tracking and metrics.

  • Replaces all UUID references with ULID across the codebase
  • Updates package dependencies to use ulid instead of uuid
  • Changes telemetry service methods to accept ULID parameters instead of UUID

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/shared/HistoryItem.ts Updates HistoryItem type to use ulid field instead of uuid
src/services/posthog/telemetry/TelemetryService.ts Updates all telemetry methods to accept ULID parameters
src/core/task/message-state.ts Updates MessageStateHandler to use ULID instead of UUID
src/core/task/index.ts Updates Task class to generate and use ULIDs, imports ulid library
src/core/task/ToolExecutor.ts Updates ToolExecutor to use ULID parameter
src/core/controller/models/refreshGroqModels.ts Updates error handling to use ULID from task
package.json Replaces uuid and @types/uuid dependencies with ulid

@arafatkatze arafatkatze changed the title Switch to ULID from UUID for tasks Switch to ULID from UUID for tasks telemetry Aug 7, 2025
@auroter auroter self-requested a review August 7, 2025 02:43
Copy link
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

✅ Coverage increased or remained the same

Overall Assessment

Test coverage has been maintained or improved

Last updated: 2025-08-07T02:45:42.743546

@arafatkatze arafatkatze merged commit 47a2ae8 into main Aug 7, 2025
13 checks passed
dtrugman pushed a commit to dtrugman/cline that referenced this pull request Aug 24, 2025
* feat: add Issue Fixer Orchestrator mode

* feat(pr-fixer-orchestrator): enhance workflow safety and user control

- Add user approval checkpoint before committing changes
- Implement large diff handling (>2000 lines) with automatic summarization
- Replace dangerous `git add -A` with selective file staging
- Enforce context preservation in shared temp directory for all delegated tasks
- Add exact PR template format specification
- Update best practices to reflect new safety measures

BREAKING CHANGE: Workflow now requires explicit user approval before commits

* removed files that were added accidently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants