-
Notifications
You must be signed in to change notification settings - Fork 7k
Switch to ULID from UUID for tasks telemetry #5407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
214a7cf
to
d17d141
Compare
ef7aed6
to
96594ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces UUID with ULID for task tracking in telemetry, implementing a breaking change to standardize on ULID for better tracking and metrics.
- Replaces all UUID references with ULID across the codebase
- Updates package dependencies to use
ulid
instead ofuuid
- Changes telemetry service methods to accept ULID parameters instead of UUID
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/shared/HistoryItem.ts | Updates HistoryItem type to use ulid field instead of uuid |
src/services/posthog/telemetry/TelemetryService.ts | Updates all telemetry methods to accept ULID parameters |
src/core/task/message-state.ts | Updates MessageStateHandler to use ULID instead of UUID |
src/core/task/index.ts | Updates Task class to generate and use ULIDs, imports ulid library |
src/core/task/ToolExecutor.ts | Updates ToolExecutor to use ULID parameter |
src/core/controller/models/refreshGroqModels.ts | Updates error handling to use ULID from task |
package.json | Replaces uuid and @types/uuid dependencies with ulid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-07T02:45:42.743546 |
* feat: add Issue Fixer Orchestrator mode * feat(pr-fixer-orchestrator): enhance workflow safety and user control - Add user approval checkpoint before committing changes - Implement large diff handling (>2000 lines) with automatic summarization - Replace dangerous `git add -A` with selective file staging - Enforce context preservation in shared temp directory for all delegated tasks - Add exact PR template format specification - Update best practices to reflect new safety measures BREAKING CHANGE: Workflow now requires explicit user approval before commits * removed files that were added accidently
Followup to #5379
Description
This PR just force switches all telemetry to use ULID instead of UUID. Since UUID has been in prod for such a short time we can either keep it as it is right now or we can force move to ULID and then that becomes the standard for now. Since its been a short while I am just doing a force move to this without any migration.
Test Procedure
Type of Change
Pre-flight Checklist
npm test
) and code is formatted and linted (npm run format && npm run lint
)npm run changeset
(required for user-facing changes)Screenshots
Additional Notes
Important
Switch from UUID to ULID for task identification across the codebase, affecting telemetry, task management, and error handling.
uuid
toulid
for task identification inToolExecutor.ts
,index.ts
, andTelemetryService.ts
.uuid
package and addulid
package inpackage.json
.TelemetryService.ts
to useulid
instead ofuuid
.uuid
withulid
for task IDs inTask
class inindex.ts
andToolExecutor
class inToolExecutor.ts
.HistoryItem
type inHistoryItem.ts
to useulid
instead ofuuid
.This description was created by
for 27c83c8. You can customize this summary. It will automatically update as commits are pushed.