Skip to content

Conversation

0xToshii
Copy link
Contributor

@0xToshii 0xToshii commented Aug 6, 2025

Related Issue

Issue: #XXXX

Description

Completes the implementation started with #5167 for adding auth key for the ollama provider when connecting to the cloud.

Test Procedure

I dont have access to a key that works here, but i've specifically tested that the key state works as expected and that there is no regression to running ollama locally.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

ollama.mov

Additional Notes

0xToshii and others added 3 commits August 6, 2025 13:45
Co-authored-by: EndoTheDev <endothedev@gmail.com>
Copy link

changeset-bot bot commented Aug 6, 2025

⚠️ No Changeset found

Latest commit: 535f0b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

⚠️ Warning: Coverage decreased by 0.01%

Consider adding tests to cover your changes.

Overall Assessment

⚠️ Test coverage has decreased in this PR

Please consider adding tests to maintain or improve coverage.

Last updated: 2025-08-06T21:14:23.516807

@0xToshii 0xToshii changed the title To/ollama deployment auth Add ollama key for cloud endpoint Aug 6, 2025
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have an ollama endpoint that requires api key to test but qa'ed the UI change and it's working as described. The UI could use a little work to make it less jumpy though.

Screen.Recording.2025-08-06.at.2.31.10.PM.mov

@0xToshii 0xToshii merged commit 9e49334 into main Aug 6, 2025
13 checks passed
@EndoTheDev
Copy link
Contributor

as the "default ollama hosting endpoint" http://ollama.com should be sufficient.
you will need to get a key from ollama.com.

@EndoTheDev
Copy link
Contributor

EndoTheDev commented Aug 7, 2025

okay i was able to test your implementation.
it starts fine as already seen above which is good.
image
but i am getting the error above.
i would suggest someone else to also check.
just copy the settings above and get a key from ollama.com/settings/keys.
as soon as you enter the base url, the model selector changes and lets you already select the available models.
you just need a key for the actual request.

@0xToshii
Copy link
Contributor Author

0xToshii commented Aug 8, 2025

@EndoTheDev its pretty unclear to me from reading their docs how the ollama cloud endpoint is supposed to work. am i supposed to set up specific models / pay ahead of time / need to use the subscription / what models are even available?

if you can figure out how to get this working please make a new pull request. now that we have the key in, im hoping any other changes will be minimal

@EndoTheDev
Copy link
Contributor

@0xToshii from what i know and all that is subject to change.

  • current state of ollama turbo is preview.
  • they will optimize the feature using the current available models and add more models later on per reques and demand.
  • there will be a subscription plan (where you have an amount of token per month)
  • there will also be a pay per token plan for user that needs more than the normal tier allows (kinda like open-router - same same but different)

i forwarded your question to maintainer too. maybe they will reach out themself.
but i think this gives an idea. there is also ollama.com/turbo that already answers a few more questions.

on the testing topic:
i am not sure if i do something wrong or not.
it seems like the changes are already in [3.21.0]. so i tried testing it but i am getting another error now.
image
it should actually tell me that i am out of tokens. 😓

please let me know what else you need and what else i can help with. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants