-
Notifications
You must be signed in to change notification settings - Fork 7k
Add ollama key for cloud endpoint #5400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% Consider adding tests to cover your changes. Overall AssessmentPlease consider adding tests to maintain or improve coverage. Last updated: 2025-08-06T21:14:23.516807 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have an ollama endpoint that requires api key to test but qa'ed the UI change and it's working as described. The UI could use a little work to make it less jumpy though.
Screen.Recording.2025-08-06.at.2.31.10.PM.mov
as the "default ollama hosting endpoint" |
okay i was able to test your implementation. |
@EndoTheDev its pretty unclear to me from reading their docs how the ollama cloud endpoint is supposed to work. am i supposed to set up specific models / pay ahead of time / need to use the subscription / what models are even available? if you can figure out how to get this working please make a new pull request. now that we have the key in, im hoping any other changes will be minimal |
@0xToshii from what i know and all that is subject to change.
i forwarded your question to maintainer too. maybe they will reach out themself. on the testing topic: please let me know what else you need and what else i can help with. 🙏 |
Related Issue
Issue: #XXXX
Description
Completes the implementation started with #5167 for adding auth key for the ollama provider when connecting to the cloud.
Test Procedure
I dont have access to a key that works here, but i've specifically tested that the key state works as expected and that there is no regression to running ollama locally.
Type of Change
Pre-flight Checklist
npm test
) and code is formatted and linted (npm run format && npm run lint
)npm run changeset
(required for user-facing changes)Screenshots
ollama.mov
Additional Notes