Revert unnecessary terminal command issue workarounds #5463
Conversation
…e periods or fast command workarounds
🦋 Changeset detectedLatest commit: d5bf480 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies terminal command handling by removing complex fallback mechanisms that were causing webview blocking issues. The change eliminates grace periods, hardcoded fast command handling, and various timers that were previously used to manage command completion detection.
Key changes:
- Simplified the command execution flow by removing multiple fallback mechanisms
- Eliminated grace period timers and complex command completion detection logic
- Streamlined the shell integration and non-shell integration code paths into a single unified approach
| if (!didOutputNonCommand) { | ||
| const lines = data.split("\n") | ||
| for (let i = 0; i < lines.length; i++) { | ||
| if (command.includes(lines[i].trim())) { |
There was a problem hiding this comment.
Use strict equality for command echo removal rather than relying on substring matching (using 'includes') to avoid accidentally removing legitimate output.
| if (command.includes(lines[i].trim())) { | |
| if (command.trim() === lines[i].trim()) { |
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-09T01:28:13.682903 |
|
|
After adding the terminal output capture fallback for commands that returned no output, it removed the need for us to use the various fallbacks we had in place around grace periods and hardcoded fast command handling that MAY have been the root cause of the issues users report about commands putting the webview in a blocked state.
Important
Refactor
TerminalProcessto improve command handling by removing grace periods and using terminal output capture fallback.run()inTerminalProcess.tsto remove grace periods and hardcoded fast command handling.completedandcontinueevents after command execution.This description was created by
for 08f135a. You can customize this summary. It will automatically update as commits are pushed.