Skip to content

Conversation

pashpashpash
Copy link
Contributor

@pashpashpash pashpashpash commented Aug 4, 2025

Related Issue

Issue: #XXXX

Description

Test Procedure

Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • πŸ’… Cosmetic Changes
  • πŸ“š Documentation update
  • πŸƒ Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes


Important

Add provider flag to CLI for specifying API provider in diff editing evaluations.

  • CLI Changes:
    • Added --provider option to runDiffEval command in index.ts and runDiffEval.ts.
    • Default provider set to openrouter.
  • API Handling:
    • Updated ClineWrapper.ts to use OpenRouterHandler or OpenAiNativeHandler based on provider.
    • Modified runSingleEvaluation() to handle provider-specific logic.
  • Test Runner:
    • Updated NodeTestRunner in TestRunner.ts to initialize with a provider.
    • Ensured API key checks are provider-specific.
  • Dashboard:
    • Updated app.py to handle new error codes and descriptions related to provider usage.
  • Types:
    • Added provider to TestInput interface in types.ts.

This description was created by Ellipsis for 9c599ae. You can customize this summary. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: 9c599ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 4, 2025

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

βœ… Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

βœ… Coverage increased or remained the same

Overall Assessment

βœ… Test coverage has been maintained or improved

Last updated: 2025-08-04T21:07:18.196401

@pashpashpash pashpashpash marked this pull request as ready for review August 5, 2025 02:49
@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 02:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds provider support to the diff-edits evaluation CLI, enabling the use of either OpenRouter or OpenAI as the API provider. The change allows users to specify --provider openai or --provider openrouter when running evaluations.

  • Added provider configuration option with OpenAI support alongside existing OpenRouter functionality
  • Updated CLI interface to accept provider parameter across evaluation commands
  • Enhanced dashboard error handling and display for better debugging experience

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
evals/diff-edits/types.ts Added optional provider field to TestInput interface
evals/diff-edits/TestRunner.ts Added provider parameter to constructor and CLI option handling
evals/diff-edits/ClineWrapper.ts Implemented provider-specific API handler initialization for OpenAI and OpenRouter
evals/cli/src/index.ts Added provider CLI option to main command interface
evals/cli/src/commands/runDiffEval.ts Updated command handler to pass provider option to underlying evaluation
evals/diff-edits/dashboard/app.py Enhanced error reporting with detailed descriptions and guidance
Comments suppressed due to low confidence (1)

evals/diff-edits/ClineWrapper.ts:211

  • [nitpick] The variable name openAiOptions is inconsistent with the naming pattern used for openRouterOptions. Consider using openAiNativeOptions to match the handler class name OpenAiNativeHandler.
					const openAiOptions = {

@pashpashpash pashpashpash merged commit 6255ac0 into main Aug 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants