Add comment about testing fix #5329
Conversation
🦋 Changeset detectedLatest commit: ba5fdea The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comment about a testing fix to clarify a potential issue with the CI/CD workflow where tests might not run against the latest version of main if the main branch is updated after PR review.
- Adds explanatory comment about timing issue with test execution in CI pipeline
| @@ -97,6 +97,7 @@ jobs: | |||
| run: npm run pretest | |||
|
|
|||
| # Unit Tests disabled due to module system conflicts between backend and webview-ui | |||
| # FIX: Right now the tests are run when the PR is being reviewed, but if main is updated after that, the PR can merge without the tests being run on the latest version of main. | |||
There was a problem hiding this comment.
The comment describes a problem but doesn't indicate what the fix is or when it will be implemented. Consider rephrasing to 'TODO:' or 'FIXME:' and include information about the planned solution or timeline.
| # FIX: Right now the tests are run when the PR is being reviewed, but if main is updated after that, the PR can merge without the tests being run on the latest version of main. | |
| # TODO: Ensure tests are run on the latest version of main before merging PRs. Planned: Investigate GitHub Actions 'require latest main' workflow by Q3 2024. |
Copilot uses AI. Check for mistakes.
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-04T00:22:51.066142 |
Important
Adds a comment in
test.ymlabout a potential issue with tests not running on the latestmainbefore PR merge..github/workflows/test.ymlhighlighting a potential issue where PRs can merge without tests being run on the latest version ofmainifmainis updated after the PR review.This description was created by
for 4db088e. You can customize this summary. It will automatically update as commits are pushed.